код написан

backend/src/services/__tests__/test_health_service.py

@@ -0,0 +1,85 @@
+import pytest
+from datetime import datetime, timedelta
+from unittest.mock import MagicMock
+from src.services.health_service import HealthService
+from src.models.llm import ValidationRecord
+
+# [DEF:test_health_service:Module]
+# @TIER: STANDARD
+# @PURPOSE: Unit tests for HealthService aggregation logic.
+
+@pytest.mark.asyncio
+async def test_get_health_summary_aggregation():
+    """
+    @TEST_SCENARIO: Verify that HealthService correctly aggregates the latest record per dashboard.
+    """
+    # Setup: Mock DB session
+    db = MagicMock()
+    
+    now = datetime.utcnow()
+    
+    # Dashboard 1: Old FAIL, New PASS
+    rec1_old = ValidationRecord(
+        dashboard_id="dash_1",
+        environment_id="env_1",
+        status="FAIL",
+        timestamp=now - timedelta(hours=1),
+        summary="Old failure",
+        issues=[]
+    )
+    rec1_new = ValidationRecord(
+        dashboard_id="dash_1",
+        environment_id="env_1",
+        status="PASS",
+        timestamp=now,
+        summary="New pass",
+        issues=[]
+    )
+    
+    # Dashboard 2: Single WARN
+    rec2 = ValidationRecord(
+        dashboard_id="dash_2",
+        environment_id="env_1",
+        status="WARN",
+        timestamp=now,
+        summary="Warning",
+        issues=[]
+    )
+    
+    # Mock the query chain
+    # subquery = self.db.query(...).filter(...).group_by(...).subquery()
+    # query = self.db.query(ValidationRecord).join(subquery, ...).all()
+    
+    mock_query = db.query.return_value
+    mock_query.filter.return_value = mock_query
+    mock_query.group_by.return_value = mock_query
+    mock_query.subquery.return_value = MagicMock()
+    
+    db.query.return_value.join.return_value.all.return_value = [rec1_new, rec2]
+    
+    service = HealthService(db)
+    summary = await service.get_health_summary(environment_id="env_1")
+    
+    assert summary.pass_count == 1
+    assert summary.warn_count == 1
+    assert summary.fail_count == 0
+    assert len(summary.items) == 2
+    
+    # Verify dash_1 has the latest status (PASS)
+    dash_1_item = next(item for item in summary.items if item.dashboard_id == "dash_1")
+    assert dash_1_item.status == "PASS"
+    assert dash_1_item.summary == "New pass"
+
+@pytest.mark.asyncio
+async def test_get_health_summary_empty():
+    """
+    @TEST_SCENARIO: Verify behavior with no records.
+    """
+    db = MagicMock()
+    db.query.return_value.join.return_value.all.return_value = []
+    
+    service = HealthService(db)
+    summary = await service.get_health_summary(environment_id="env_none")
+    
+    assert summary.pass_count == 0
+    assert len(summary.items) == 0

backend/src/services/__tests__/test_llm_plugin_persistence.py

@@ -0,0 +1,150 @@
+# [DEF:backend.src.services.__tests__.test_llm_plugin_persistence:Module]
+# @TIER: STANDARD
+# @PURPOSE: Regression test for ValidationRecord persistence fields populated from task context.
+
+import types
+import pytest
+
+from src.plugins.llm_analysis import plugin as plugin_module
+
+
+# [DEF:_DummyLogger:Class]
+# @PURPOSE: Minimal logger shim for TaskContext-like objects used in tests.
+class _DummyLogger:
+    def with_source(self, _source: str):
+        return self
+
+    def info(self, *_args, **_kwargs):
+        return None
+
+    def debug(self, *_args, **_kwargs):
+        return None
+
+    def warning(self, *_args, **_kwargs):
+        return None
+
+    def error(self, *_args, **_kwargs):
+        return None
+# [/DEF:_DummyLogger:Class]
+
+
+# [DEF:_FakeDBSession:Class]
+# @PURPOSE: Captures persisted records for assertion and mimics SQLAlchemy session methods used by plugin.
+class _FakeDBSession:
+    def __init__(self):
+        self.added = None
+        self.committed = False
+        self.closed = False
+
+    def add(self, obj):
+        self.added = obj
+
+    def commit(self):
+        self.committed = True
+
+    def close(self):
+        self.closed = True
+# [/DEF:_FakeDBSession:Class]
+
+
+# [DEF:test_dashboard_validation_plugin_persists_task_and_environment_ids:Function]
+# @PURPOSE: Ensure db ValidationRecord includes context.task_id and params.environment_id.
+@pytest.mark.asyncio
+async def test_dashboard_validation_plugin_persists_task_and_environment_ids(tmp_path, monkeypatch):
+    fake_db = _FakeDBSession()
+
+    env = types.SimpleNamespace(id="env-42")
+    provider = types.SimpleNamespace(
+        id="provider-1",
+        name="Main LLM",
+        provider_type="openai",
+        base_url="https://example.invalid/v1",
+        default_model="gpt-4o",
+        is_active=True,
+    )
+
+    class _FakeProviderService:
+        def __init__(self, _db):
+            return None
+
+        def get_provider(self, _provider_id):
+            return provider
+
+        def get_decrypted_api_key(self, _provider_id):
+            return "a" * 32
+
+    class _FakeScreenshotService:
+        def __init__(self, _env):
+            return None
+
+        async def capture_dashboard(self, _dashboard_id, _screenshot_path):
+            return None
+
+    class _FakeLLMClient:
+        def __init__(self, **_kwargs):
+            return None
+
+        async def analyze_dashboard(self, *_args, **_kwargs):
+            return {
+                "status": "PASS",
+                "summary": "Dashboard healthy",
+                "issues": [],
+            }
+
+    class _FakeNotificationService:
+        def __init__(self, *_args, **_kwargs):
+            return None
+
+        async def dispatch_report(self, **_kwargs):
+            return None
+
+    class _FakeConfigManager:
+        def get_environment(self, _env_id):
+            return env
+
+        def get_config(self):
+            return types.SimpleNamespace(
+                settings=types.SimpleNamespace(
+                    storage=types.SimpleNamespace(root_path=str(tmp_path)),
+                    llm={},
+                )
+            )
+
+    class _FakeSupersetClient:
+        def __init__(self, _env):
+            self.network = types.SimpleNamespace(request=lambda **_kwargs: {"result": []})
+
+    monkeypatch.setattr(plugin_module, "SessionLocal", lambda: fake_db)
+    monkeypatch.setattr(plugin_module, "LLMProviderService", _FakeProviderService)
+    monkeypatch.setattr(plugin_module, "ScreenshotService", _FakeScreenshotService)
+    monkeypatch.setattr(plugin_module, "LLMClient", _FakeLLMClient)
+    monkeypatch.setattr(plugin_module, "NotificationService", _FakeNotificationService)
+    monkeypatch.setattr(plugin_module, "SupersetClient", _FakeSupersetClient)
+    monkeypatch.setattr("src.dependencies.get_config_manager", lambda: _FakeConfigManager())
+
+    context = types.SimpleNamespace(
+        task_id="task-999",
+        logger=_DummyLogger(),
+        background_tasks=None,
+    )
+
+    plugin = plugin_module.DashboardValidationPlugin()
+    result = await plugin.execute(
+        {
+            "dashboard_id": "11",
+            "environment_id": "env-42",
+            "provider_id": "provider-1",
+        },
+        context=context,
+    )
+
+    assert result["environment_id"] == "env-42"
+    assert fake_db.committed is True
+    assert fake_db.closed is True
+    assert fake_db.added is not None
+    assert fake_db.added.task_id == "task-999"
+    assert fake_db.added.environment_id == "env-42"
+# [/DEF:test_dashboard_validation_plugin_persists_task_and_environment_ids:Function]
+
+
+# [/DEF:backend.src.services.__tests__.test_llm_plugin_persistence:Module]