semantic update

backend/src/core/task_manager/persistence.py

@@ -1,4 +1,5 @@
 # [DEF:TaskPersistenceModule:Module]
+# @TIER: CRITICAL
 # @SEMANTICS: persistence, sqlite, sqlalchemy, task, storage
 # @PURPOSE: Handles the persistence of tasks using SQLAlchemy and the tasks.db database.
 # @LAYER: Core
@@ -19,42 +20,65 @@ from ..logger import logger, belief_scope
 # [/SECTION]
 
 # [DEF:TaskPersistenceService:Class]
+# @TIER: CRITICAL
 # @SEMANTICS: persistence, service, database, sqlalchemy
 # @PURPOSE: Provides methods to save and load tasks from the tasks.db database using SQLAlchemy.
+# @INVARIANT: Persistence must handle potentially missing task fields natively.
 class TaskPersistenceService:
+    # [DEF:_json_load_if_needed:Function]
+    # @PURPOSE: Safely load JSON strings from DB if necessary
+    # @PRE: value is an arbitrary database value
+    # @POST: Returns parsed JSON object, list, string, or primitive
     @staticmethod
     def _json_load_if_needed(value):
-        if value is None:
-            return None
-        if isinstance(value, (dict, list)):
-            return value
-        if isinstance(value, str):
-            stripped = value.strip()
-            if stripped == "" or stripped.lower() == "null":
+        with belief_scope("TaskPersistenceService._json_load_if_needed"):
+            if value is None:
                 return None
-            try:
-                return json.loads(stripped)
-            except json.JSONDecodeError:
+            if isinstance(value, (dict, list)):
                 return value
-        return value
+            if isinstance(value, str):
+                stripped = value.strip()
+                if stripped == "" or stripped.lower() == "null":
+                    return None
+                try:
+                    return json.loads(stripped)
+                except json.JSONDecodeError:
+                    return value
+            return value
+    # [/DEF:_json_load_if_needed:Function]
 
+    # [DEF:_parse_datetime:Function]
+    # @PURPOSE: Safely parse a datetime string from the database
+    # @PRE: value is an ISO string or datetime object
+    # @POST: Returns datetime object or None
     @staticmethod
     def _parse_datetime(value):
-        if value is None or isinstance(value, datetime):
-            return value
-        if isinstance(value, str):
-            try:
-                return datetime.fromisoformat(value)
-            except ValueError:
-                return None
-        return None
-
-    @staticmethod
-    def _resolve_environment_id(session: Session, env_id: Optional[str]) -> Optional[str]:
-        if not env_id:
+        with belief_scope("TaskPersistenceService._parse_datetime"):
+            if value is None or isinstance(value, datetime):
+                return value
+            if isinstance(value, str):
+                try:
+                    return datetime.fromisoformat(value)
+                except ValueError:
+                    return None
             return None
-        exists = session.query(Environment.id).filter(Environment.id == env_id).first()
-        return env_id if exists else None
+    # [/DEF:_parse_datetime:Function]
+
+    # [DEF:_resolve_environment_id:Function]
+    # @TIER: STANDARD
+    # @PURPOSE: Resolve environment id based on provided value or fallback to default
+    # @PRE: Session is active
+    # @POST: Environment ID is returned
+    @staticmethod
+    def _resolve_environment_id(session: Session, env_id: Optional[str]) -> str:
+        with belief_scope("_resolve_environment_id"):
+            if env_id:
+                return env_id
+            repo_env = session.query(Environment).filter_by(name="default").first()
+            if repo_env:
+                return str(repo_env.id)
+            return "default"
+    # [/DEF:_resolve_environment_id:Function]
 
     # [DEF:__init__:Function]
     # @PURPOSE: Initializes the persistence service.
@@ -90,13 +114,14 @@ class TaskPersistenceService:
                 
                 # Ensure params and result are JSON serializable
                 def json_serializable(obj):
-                    if isinstance(obj, dict):
-                        return {k: json_serializable(v) for k, v in obj.items()}
-                    elif isinstance(obj, list):
-                        return [json_serializable(v) for v in obj]
-                    elif isinstance(obj, datetime):
-                        return obj.isoformat()
-                    return obj
+                    with belief_scope("TaskPersistenceService.json_serializable"):
+                        if isinstance(obj, dict):
+                            return {k: json_serializable(v) for k, v in obj.items()}
+                        elif isinstance(obj, list):
+                            return [json_serializable(v) for v in obj]
+                        elif isinstance(obj, datetime):
+                            return obj.isoformat()
+                        return obj
 
                 record.params = json_serializable(task.params)
                 record.result = json_serializable(task.result)
@@ -227,9 +252,11 @@ class TaskLogPersistenceService:
     """
     
     # [DEF:__init__:Function]
-    # @PURPOSE: Initialize the log persistence service.
-    # @POST: Service is ready.
-    def __init__(self):
+    # @TIER: STANDARD
+    # @PURPOSE: Initializes the TaskLogPersistenceService
+    # @PRE: config is provided or defaults are used
+    # @POST: Service is ready for log persistence
+    def __init__(self, config=None):
         pass
     # [/DEF:__init__:Function]