semantic update

backend/src/api/routes/migration.py

@@ -26,7 +26,7 @@ from ...dependencies import get_config_manager, get_task_manager, has_permission
 from ...core.database import get_db
 from ...models.dashboard import DashboardMetadata, DashboardSelection
 from ...core.superset_client import SupersetClient
-from ...core.logger import belief_scope
+from ...core.logger import logger, belief_scope
 from ...core.migration.dry_run_orchestrator import MigrationDryRunService
 from ...core.mapping_service import IdMappingService
 from ...models.mapping import ResourceMapping
@@ -46,14 +46,18 @@ async def get_dashboards(
     _ = Depends(has_permission("plugin:migration", "EXECUTE"))
 ):
     with belief_scope("get_dashboards", f"env_id={env_id}"):
+        logger.reason(f"Fetching dashboards for environment: {env_id}")
         environments = config_manager.get_environments()
-    env = next((e for e in environments if e.id == env_id), None)
-    if not env:
-        raise HTTPException(status_code=404, detail="Environment not found")
+        env = next((e for e in environments if e.id == env_id), None)
+        
+        if not env:
+            logger.explore(f"Environment {env_id} not found in configuration")
+            raise HTTPException(status_code=404, detail="Environment not found")
 
-    client = SupersetClient(env)
-    dashboards = client.get_dashboards_summary()
-    return dashboards
+        client = SupersetClient(env)
+        dashboards = client.get_dashboards_summary()
+        logger.reflect(f"Retrieved {len(dashboards)} dashboards from {env_id}")
+        return dashboards
 # [/DEF:get_dashboards:Function]
 
 # [DEF:execute_migration:Function]
@@ -70,31 +74,30 @@ async def execute_migration(
     _ = Depends(has_permission("plugin:migration", "EXECUTE"))
 ):
     with belief_scope("execute_migration"):
+        logger.reason(f"Initiating migration from {selection.source_env_id} to {selection.target_env_id}")
+        
         # Validate environments exist
         environments = config_manager.get_environments()
-    env_ids = {e.id for e in environments}
-    if selection.source_env_id not in env_ids or selection.target_env_id not in env_ids:
-        raise HTTPException(status_code=400, detail="Invalid source or target environment")
+        env_ids = {e.id for e in environments}
+        
+        if selection.source_env_id not in env_ids or selection.target_env_id not in env_ids:
+            logger.explore("Invalid environment selection", extra={"source": selection.source_env_id, "target": selection.target_env_id})
+            raise HTTPException(status_code=400, detail="Invalid source or target environment")
 
-    # Create migration task with debug logging
-    from ...core.logger import logger
-    
-    # Include replace_db_config and fix_cross_filters in the task parameters
-    task_params = selection.dict()
-    task_params['replace_db_config'] = selection.replace_db_config
-    task_params['fix_cross_filters'] = selection.fix_cross_filters
-    
-    logger.info(f"Creating migration task with params: {task_params}")
-    logger.info(f"Available environments: {env_ids}")
-    logger.info(f"Source env: {selection.source_env_id}, Target env: {selection.target_env_id}")
-    
-    try:
-        task = await task_manager.create_task("superset-migration", task_params)
-        logger.info(f"Task created successfully: {task.id}")
-        return {"task_id": task.id, "message": "Migration initiated"}
-    except Exception as e:
-        logger.error(f"Task creation failed: {e}")
-        raise HTTPException(status_code=500, detail=f"Failed to create migration task: {str(e)}")
+        # Include replace_db_config and fix_cross_filters in the task parameters
+        task_params = selection.dict()
+        task_params['replace_db_config'] = selection.replace_db_config
+        task_params['fix_cross_filters'] = selection.fix_cross_filters
+        
+        logger.reason(f"Creating migration task with {len(selection.selected_ids)} dashboards")
+        
+        try:
+            task = await task_manager.create_task("superset-migration", task_params)
+            logger.reflect(f"Migration task created: {task.id}")
+            return {"task_id": task.id, "message": "Migration initiated"}
+        except Exception as e:
+            logger.explore(f"Task creation failed: {e}")
+            raise HTTPException(status_code=500, detail=f"Failed to create migration task: {str(e)}")
 # [/DEF:execute_migration:Function]
 
 
@@ -112,29 +115,41 @@ async def dry_run_migration(
     _ = Depends(has_permission("plugin:migration", "EXECUTE"))
 ):
     with belief_scope("dry_run_migration"):
+        logger.reason(f"Starting dry run: {selection.source_env_id} -> {selection.target_env_id}")
+        
         environments = config_manager.get_environments()
-    env_map = {env.id: env for env in environments}
-    source_env = env_map.get(selection.source_env_id)
-    target_env = env_map.get(selection.target_env_id)
-    if not source_env or not target_env:
-        raise HTTPException(status_code=400, detail="Invalid source or target environment")
-    if selection.source_env_id == selection.target_env_id:
-        raise HTTPException(status_code=400, detail="Source and target environments must be different")
-    if not selection.selected_ids:
-        raise HTTPException(status_code=400, detail="No dashboards selected for dry run")
+        env_map = {env.id: env for env in environments}
+        source_env = env_map.get(selection.source_env_id)
+        target_env = env_map.get(selection.target_env_id)
+        
+        if not source_env or not target_env:
+            logger.explore("Invalid environment selection for dry run")
+            raise HTTPException(status_code=400, detail="Invalid source or target environment")
+        
+        if selection.source_env_id == selection.target_env_id:
+            logger.explore("Source and target environments are identical")
+            raise HTTPException(status_code=400, detail="Source and target environments must be different")
+        
+        if not selection.selected_ids:
+            logger.explore("No dashboards selected for dry run")
+            raise HTTPException(status_code=400, detail="No dashboards selected for dry run")
 
-    service = MigrationDryRunService()
-    source_client = SupersetClient(source_env)
-    target_client = SupersetClient(target_env)
-    try:
-        return service.run(
-            selection=selection,
-            source_client=source_client,
-            target_client=target_client,
-            db=db,
-        )
-    except ValueError as exc:
-        raise HTTPException(status_code=500, detail=str(exc)) from exc
+        service = MigrationDryRunService()
+        source_client = SupersetClient(source_env)
+        target_client = SupersetClient(target_env)
+        
+        try:
+            result = service.run(
+                selection=selection,
+                source_client=source_client,
+                target_client=target_client,
+                db=db,
+            )
+            logger.reflect("Dry run analysis complete")
+            return result
+        except ValueError as exc:
+            logger.explore(f"Dry run orchestrator failed: {exc}")
+            raise HTTPException(status_code=500, detail=str(exc)) from exc
 # [/DEF:dry_run_migration:Function]
 
 # [DEF:get_migration_settings:Function]